Fix for #605 #606
Merged
Fix for #605 #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adorton-adobe can you take a look at this despite the failed builds? I think we are having unrelated build issues on centos again. This is a fairly urgent fix for @Tomomi99145 #605 It's because the dynamic imports do not work correctly with the frozen bundle. This applies to the admin console connector and post sync. |
|
I'll need to fix the build issues before we can merge. I think I know what is happening. |
adorton-adobe
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #605. Dynamic import doesn't work correctly in pyinstaller build if we don't pre-import the connectors.