Replace / Remove unused methods #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vossen-adobe
changed the title
|
Also, the ubuntu 3.6 build is failing because of a jeepney dependency issue (across the board I think) |
adorton-adobe
requested changes
Aug 19, 2019
|
@vossen-adobe - just a reminder that we can't merge this until all CI checks pass |
|
@adorton-adobe Good to go! |
adorton-adobe
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_stray_key_map simply returns an empty dictionary and is only used once in the code. It makes sense to remove it. The return value no longer matches the comments, so I'm assuming it had a greater purpose in the past.
Also, several methods are no longer used anywhere in the code:
calculate_groups_to_add
calculate_groups_to_remove
get_new _groups
Removed these.