Skip to content

garbage collecting connection and no more ngx.timer - memory leak #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2018
Merged

garbage collecting connection and no more ngx.timer - memory leak #2

merged 1 commit into from
Aug 8, 2018

Conversation

atrifan
Copy link
Member

@atrifan atrifan commented May 25, 2018

  • no more ngx.timer
  • ffi.gc to garbage collect with destryo
  • ngx.timer produces memory leak

@atrifan
Copy link
Member Author

atrifan commented Jul 19, 2018

@vdatcu @andralungu please look over this PR needs to be merged as soon as possible thanks

@atrifan atrifan merged commit d7e10ce into master Aug 8, 2018
@atrifan atrifan deleted the garbage_collect_connections branch August 8, 2018 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@constantincristian constantincristian constantincristian approved these changes

@ddragosd ddragosd Awaiting requested review from ddragosd

@andralungu andralungu Awaiting requested review from andralungu

@corinapurcarea corinapurcarea Awaiting requested review from corinapurcarea

@vdatcu vdatcu Awaiting requested review from vdatcu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atrifan @constantincristian