Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add httpAgent as right now the connection is not kept alive #612

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

vrunoa
Copy link
Contributor

@vrunoa vrunoa commented Jan 7, 2020

Currently, the connection is not keep-alive over a test life, during some investigation at Sauce I notice this Appium(webdriver) client is closing TCP connections before any new command.
Here's some Wireshark TCP dump showing it:

before-keep-alive

👆🏻Before any new command(request) there's a [FIN, ACK]


With these changes looking at TCP dumps we can see the socket is kept open, so there's no more resync before new requests 👇🏻

after-keep-alive

@vrunoa
Copy link
Contributor Author

vrunoa commented Jan 7, 2020

@imurchie here we go again 😃

Copy link
Collaborator

@imurchie imurchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@imurchie imurchie merged commit 1432cc5 into admc:master Jan 7, 2020
@imurchie
Copy link
Collaborator

imurchie commented Jan 7, 2020

I don't have the ability to publish this, but I've pinged @jlipps on Slack about it.

@vrunoa
Copy link
Contributor Author

vrunoa commented Jan 8, 2020

@imurchie @jlipps if I create a patch for an old version of wd, once we use internally to sauce, could be considered for publishing?

@imurchie
Copy link
Collaborator

imurchie commented Jan 8, 2020

@vrunoa Any idea about how to mitigate the problem this is causing in the Appium build?

For instance, https://travis-ci.org/appium/appium/jobs/634369625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants