Update rules_foreign_cc to version 0.2.0

Summary:
Re-applying D8034, with a Jenkins fix.

Had to change the tar command in the Jenkinsfile to use `--no-same-owner`, otherwise the owner of some third_party files would be invalid users, and this would cause problems with cmake, where cmake would fail with "failed to preserve ownership" messages.

Test Plan: Jenkins

Reviewers: zasgar, #third_party_approvers, jamesbartlett

Reviewed By: zasgar, #third_party_approvers

Differential Revision: https://phab.corp.pixielabs.ai/D8087

GitOrigin-RevId: 546708e

Jenkinsfile

@@ -175,8 +175,11 @@ def unstashFromGCS(String name) {
 
   gsutilCopy("gs://${GCS_STASH_BUCKET}/${env.BUILD_TAG}/${srcFile}", ".archive/${srcFile}")
 
+  // Note: The tar extraction must use `--no-same-owner`.
+  // Without this, the owner of some third_party files become invalid users,
+  // which causes some cmake projects to fail with "failed to preserve ownership" messages.
   sh """
-    tar -zxf .archive/${srcFile}
+    tar -zxf .archive/${srcFile} --no-same-owner
     rm -f .archive/${srcFile}
   """
 }

WORKSPACE

@@ -56,7 +56,7 @@ load("@com_github_grpc_grpc//bazel:grpc_extra_deps.bzl", "grpc_extra_deps")
 
 grpc_extra_deps()
 
-load("@rules_foreign_cc//:workspace_definitions.bzl", "rules_foreign_cc_dependencies")
+load("@rules_foreign_cc//foreign_cc:repositories.bzl", "rules_foreign_cc_dependencies")
 
 rules_foreign_cc_dependencies()
 

bazel/repository_locations.bzl

@@ -128,11 +128,9 @@ REPOSITORY_LOCATIONS = dict(
         urls = ["https://github.com/AriaFallah/csv-parser/archive/e3c1207f4de50603a4946dc5daa0633ce31a9257.tar.gz"],
     ),
     rules_foreign_cc = dict(
-        sha256 = "3411b754d3f7a91356c27a93b6a250a6fa22999858b6d118e928c57e1888acf9",
-        strip_prefix = "rules_foreign_cc-e6ca4d2cd12be03ccda117b26d59a03de7481dc3",
-        # 2019-11-01
-        urls = ["https://github.com/bazelbuild/rules_foreign_cc/" +
-                "archive/e6ca4d2cd12be03ccda117b26d59a03de7481dc3.tar.gz"],
+        sha256 = "d54742ffbdc6924f222d2179f0e10e911c5c659c4ae74158e9fe827aad862ac6",
+        strip_prefix = "rules_foreign_cc-0.2.0",
+        urls = ["https://github.com/bazelbuild/rules_foreign_cc/archive/0.2.0.tar.gz"],
     ),
     com_github_gperftools_gperftools = dict(
         sha256 = "18574813a062eee487bc1b761e8024a346075a7cb93da19607af362dc09565ef",

third_party/foreign_cc/BUILD.bazel

@@ -1,7 +1,5 @@
 load("@rules_cc//cc:defs.bzl", "cc_library")
-load("@rules_foreign_cc//tools/build_defs:cmake.bzl", "cmake_external")
-load("@rules_foreign_cc//tools/build_defs:configure.bzl", "configure_make")
-load("@rules_foreign_cc//tools/build_defs:make.bzl", "make")
+load("@rules_foreign_cc//foreign_cc:defs.bzl", "configure_make", "cmake", "make")
 
 licenses(["notice"])
 
@@ -17,7 +15,7 @@ configure_make(
     lib_source = "@com_github_gperftools_gperftools//:all",
     linkopts = ["-lpthread"],
     make_commands = ["make install-libLTLIBRARIES install-perftoolsincludeHEADERS"],
-    static_libraries = select({
+    out_static_libs = select({
         "//bazel:debug_tcmalloc": ["libtcmalloc_debug.a"],
         "//conditions:default": ["libtcmalloc_and_profiler.a"],
     }),
@@ -31,7 +29,7 @@ cc_library(
     ],
 )
 
-cmake_external(
+cmake(
     name = "natsc",
     cache_entries = {
         # This forces nats to link against boringssl instead of openssl.
@@ -50,7 +48,7 @@ cmake_external(
     deps = ["@boringssl//:ssl"],
 )
 
-cmake_external(
+cmake(
     name = "libuv",
     cache_entries = {
         "BUILDING_UV_SHARED": "OFF",
@@ -66,7 +64,7 @@ cmake_external(
     ],
 )
 
-cmake_external(
+cmake(
     name = "libarchive",
     cache_entries = {
         "ENABLE_CAT": "OFF",
@@ -93,12 +91,12 @@ make(
     #    make_commands = ["BUILD_STATIC_ONLY=y make -C src install PREFIX=out"],
     #    out_include_dir = "out/include",
     #    out_lib_dir = "out/lib64",
-    static_libraries = [
+    out_static_libs = [
         "libbpf.a",
     ],
 )
 
-cmake_external(
+cmake(
     name = "bcc",
     generate_crosstool_file = True,
     lib_name = "libbcc_static",
@@ -109,9 +107,9 @@ cmake_external(
         "-lelf",
     ],
     make_commands = [
-        "make -j ${nproc} -C src/cc install",
+        "make -j$(nproc) -C src/cc install",
     ],
-    static_libraries = [
+    out_static_libs = [
         "libapi-static.a",
         "libbcc.a",
         "libbcc_bpf.a",