[pull] main from regenrek:main #15
Conversation
…trics - Added `@cloudflare/workers-types` as a devDependency for improved type support. - Introduced `PerformanceMetrics` interface to track performance metrics in `FetchMetadata`. - Updated `FileContent` interface to include optional properties for better file handling. - Adjusted `build.config.ts` to disable warnings during build. - Enhanced type definitions across various files for improved usability and maintainability. These changes improve the SDK's type definitions and enhance its functionality for developers working with Cloudflare Workers.
Feat/cloudflare support
![giga-agent[bot]](https://avatars.githubusercontent.com/in/1202121?s=60&v=4){kind=small}
| return parts.every((part) => { | ||
| const num = Number.parseInt(part, 10); | ||
| return !isNaN(num) && num >= 0 && num <= 255 && part === num.toString(); | ||
| return !Number.isNaN(num) && num >= 0 && num <= 255 && part === num.toString(); |
There was a problem hiding this comment.
Good improvement: Using Number.isNaN() instead of global isNaN() is more precise and safer
| const size = Number.parseInt(sizeStr, 8); | ||
| const typeFlag = String.fromCharCode(block[156]); | ||
| const typeFlag = String.fromCodePoint(block[156]); | ||
| return { |
There was a problem hiding this comment.
Good update: fromCodePoint() is more modern and has better Unicode support than fromCharCode()
| private url: string; | ||
| private result: FetchResult; | ||
| root: FileNode; | ||
| url: string; |
There was a problem hiding this comment.
Changing private fields to public may break encapsulation. Consider if this is intentional
| // Check if expired | ||
| const metadata = await kv.getWithMetadata(key); | ||
| if (metadata.metadata?.expires) { | ||
| if ( |
There was a problem hiding this comment.
Good enhancement to add type checking for metadata object structure, making the code more type-safe
| if (cacheStorage.type === "cache-api") { | ||
| const cache = cacheStorage.instance as Cache; | ||
| const _cache = cacheStorage.instance as Cache; | ||
| // Cache API doesn't support listing, so we can't clear by pattern |
There was a problem hiding this comment.
Unused variable renamed with underscore prefix, but consider removing it entirely if not used
| return parts.every((part) => { | ||
| const num = Number.parseInt(part, 10); | ||
| return !isNaN(num) && num >= 0 && num <= 255 && part === num.toString(); | ||
| return ( |
There was a problem hiding this comment.
Good change replacing isNaN() with Number.isNaN() for more precise NaN checking
| declaration: true, | ||
| clean: true, | ||
| failOnWarn: false, | ||
| externals: [ |
There was a problem hiding this comment.
Disabling build warnings could hide potential issues. Consider handling warnings instead of suppressing them.
| */ | ||
|
|
||
| // @ts-ignore - importing from built file | ||
| import { |
There was a problem hiding this comment.
Avoid using @ts-ignore. Consider fixing the underlying import issue or using @ts-expect-error with explanation if absolutely necessary.
1 participant
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by Sourcery
Introduce comprehensive enhancements to the SDK’s streaming, caching, migration, tree utilities, error handling, and type definitions, alongside build and CI updates.
New Features:
Enhancements:
Build:
CI:
Chores: