Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding 'Phone' to Socials #635

Merged
merged 3 commits into from
Jan 13, 2022
Merged

Adding 'Phone' to Socials #635

merged 3 commits into from
Jan 13, 2022

Conversation

janga1
Copy link
Contributor

@janga1 janga1 commented Nov 19, 2021

What does this PR change? What problem does it solve?

This PR adds a 'phone' svg (made myself in Figma) and the possibility to use "tel:" as a social url (e.g. "tel:0123456789").

Was the change discussed in an issue or in the Discussions before?

No

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

Remarks

It might be easier and more sensible to just pass safeURL on all social urls.

@sonarcloud
Copy link

sonarcloud bot commented Nov 19, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

adityatelange
adityatelange requested changes Jan 13, 2022
View reviewed changes
Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the mentioned changed so that we can merge this

layouts/partials/social_icons.html Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adityatelange adityatelange merged commit 54a3c60 into adityatelange:master Jan 13, 2022
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
@janga1
Adding 'Phone' to Socials (adityatelange#635)
1febe98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityatelange adityatelange adityatelange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janga1 @adityatelange