Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rgba to rgb #560

Merged
merged 12 commits into from
Sep 20, 2021
Merged

Rgba to rgb #560

merged 12 commits into from
Sep 20, 2021

Conversation

adityatelange
Copy link
Owner

@adityatelange adityatelange commented Sep 9, 2021

What does this PR change? What problem does it solve?

Because the theme's colors are set using opacity instead of actual color values, they interfere with elements other than text. For example, dark elements styled by entry-content use the --secondary color of rgba(255, 255, 255, 0.56). The text reads fine as a grey color against the black background, but if you add an emoji into your content it will also take on the 0.56 opacity value and look like it's fading away.

This PR includes: Same color, but no opacity issues.

The opacity of go to top button also changes here

Was the change discussed in an issue or in the Discussions before?

[BUG] Emojis affected by theme opacity values Fixes: #557

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

@adityatelange
Copy link
Owner Author

@aormsby @kdkasad Please check whether the colors look the same of different. Also let me know if there are any other visual differences

@adityatelange adityatelange marked this pull request as ready for review September 9, 2021 13:54
@aormsby
Copy link

aormsby commented Sep 10, 2021

@adityatelange Looks pretty solid to me 👍

Copy link
Contributor

@kdkasad kdkasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aormsby
Copy link

aormsby commented Sep 18, 2021

Just bumping this. I'd happily help deal with the conflicts, but I don't have write permission. 😅

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adityatelange adityatelange merged commit 7c930ee into master Sep 20, 2021
@adityatelange adityatelange deleted the rgba-to-rgb branch September 20, 2021 15:38
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
- Except for code-copy btn
- Emojis were affected by theme opacity values, fixes: adityatelange#557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Emojis affected by theme opacity values
3 participants