Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n support for Arabic #271

Merged
merged 3 commits into from
Mar 1, 2021

Conversation

Muhammad-Saad-01
Copy link
Contributor

No description provided.

Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Muhammad-Saad-01
Copy link
Contributor Author

ar.yaml updated with remaining changes.

@adityatelange
Copy link
Owner

ar.yaml updated with remaining changes.

I am getting these warns while building, but couldn't figure out why. Do you get these ?

WARN 2021/02/28 12:27:57 Failed to get translated string for language "ar" and ID "read_time": message "read_time" has no plural form "few"
WARN 2021/02/28 12:27:57 Failed to get translated string for language "ar" and ID "read_time": message "read_time" has no plural form "few"
WARN 2021/02/28 12:27:59 Failed to get translated string for language "ar" and ID "read_time": message "read_time" has no plural form "two"
WARN 2021/02/28 12:27:59 Failed to get translated string for language "ar" and ID "read_time": message "read_time" has no plural form "zero"

@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Muhammad-Saad-01
Copy link
Contributor Author

I didn't build it, just created the file. it just because of plural forms of counting numbers in Arabic, check it again.

@adityatelange
Copy link
Owner

I didn't build it, just created the file. it just because of plural forms of counting numbers in Arabic, check it again.

We also have Farsi in i18n list but these warings were't there, what's the catch here ?

- id: prev_page
translation: "صفحهٔ قبل"
- id: next_page
translation: "صفحهٔ بعد"
- id: read_time
translation:
one : "1 دقیقه"
other: "{{ .Count }} دقیقه"
- id: toc
translation: "فهرست مطالب"
- id: translations
translation: "ترجمه‌ها"

@adityatelange adityatelange merged commit e0ed556 into adityatelange:master Mar 1, 2021
@Muhammad-Saad-01
Copy link
Contributor Author

that's interesting, I don't know if Farsi has different plural forms or not but I will check it out :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants