-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add configurable limit to search results #1281
Merged
adityatelange
merged 2 commits into
adityatelange:master
from
pottekkat:feat/limit-search/1
Aug 12, 2023
Merged
feat: add configurable limit to search results #1281
adityatelange
merged 2 commits into
adityatelange:master
from
pottekkat:feat/limit-search/1
Aug 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Navendu Pottekkat <navendu@apache.org>
7 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throws an error Cannot read properties of null (reading 'limit')
when params.fuseOpts is not defined.
resulting into `Cannot read properties of null (reading 'limit')`
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
romainx
pushed a commit
to romainx/hugo-PaperMod
that referenced
this pull request
Aug 30, 2023
* feat: add configurable limit to search results Signed-off-by: Navendu Pottekkat <navendu@apache.org> * Handle case where params.fuseOpts is not defined resulting into `Cannot read properties of null (reading 'limit')` Utilizes search options by fuse https://www.fusejs.io/api/methods.html#search The options: limit (type: number): Denotes the max number of returned search results. --------- Signed-off-by: Navendu Pottekkat <navendu@apache.org> Co-authored-by: Aditya Telange <21258296+adityatelange@users.noreply.github.com>
zer0ttl
pushed a commit
to zer0ttl/hugo-PaperMod
that referenced
this pull request
Jan 24, 2024
* feat: add configurable limit to search results Signed-off-by: Navendu Pottekkat <navendu@apache.org> * Handle case where params.fuseOpts is not defined resulting into `Cannot read properties of null (reading 'limit')` Utilizes search options by fuse https://www.fusejs.io/api/methods.html#search The options: limit (type: number): Denotes the max number of returned search results. --------- Signed-off-by: Navendu Pottekkat <navendu@apache.org> Co-authored-by: Aditya Telange <21258296+adityatelange@users.noreply.github.com>
jdxgfty
pushed a commit
to jdxgfty/hugo-PaperMod
that referenced
this pull request
Nov 3, 2024
* feat: add configurable limit to search results Signed-off-by: Navendu Pottekkat <navendu@apache.org> * Handle case where params.fuseOpts is not defined resulting into `Cannot read properties of null (reading 'limit')` Utilizes search options by fuse https://www.fusejs.io/api/methods.html#search The options: limit (type: number): Denotes the max number of returned search results. --------- Signed-off-by: Navendu Pottekkat <navendu@apache.org> Co-authored-by: Aditya Telange <21258296+adityatelange@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Adds a configurable limit to the number of search results returned. This limit can be configured in the site's configuration file.
Was the change discussed in an issue or in the Discussions before?
Not discussed.
PR Checklist