Add unit tests for mutable_state_builder_methods_signal.go (uber#6056)

* Add unit tests for mutable_state_builder_methods_signal.go

* Update mutable_state_builder_methods_signal_test.go

* Update mutable_state_builder_methods_signal_test.go

* fix lint issues

service/history/execution/mutable_state_builder_methods_activity_test.go

@@ -31,6 +31,7 @@ import (
 	"github.com/stretchr/testify/assert"
 
 	"github.com/uber/cadence/common"
+	"github.com/uber/cadence/common/cache"
 	"github.com/uber/cadence/common/log"
 	"github.com/uber/cadence/common/persistence"
 	"github.com/uber/cadence/common/types"
@@ -61,6 +62,7 @@ func testMutableStateBuilder(t *testing.T) *mutableStateBuilder {
 
 	mockShard.Resource.MatchingClient.EXPECT().AddActivityTask(gomock.Any(), gomock.Any()).Return(nil).AnyTimes()
 	mockShard.Resource.DomainCache.EXPECT().GetDomainID(constants.TestDomainName).Return(constants.TestDomainID, nil).AnyTimes()
+	mockShard.Resource.DomainCache.EXPECT().GetDomainByID(constants.TestDomainID).Return(&cache.DomainCacheEntry{}, nil).AnyTimes()
 	return newMutableStateBuilder(mockShard, logger, constants.TestLocalDomainEntry)
 }
 

service/history/execution/mutable_state_builder_methods_signal_test.go

@@ -0,0 +1,217 @@
+// The MIT License (MIT)
+
+// Copyright (c) 2017-2020 Uber Technologies Inc.
+
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in all
+// copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+// SOFTWARE.
+
+package execution
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+
+	"github.com/uber/cadence/common/persistence"
+	"github.com/uber/cadence/common/types"
+	"github.com/uber/cadence/service/history/constants"
+)
+
+func Test__IsSignalRequested(t *testing.T) {
+	requestID := "101"
+	t.Run("signal not found", func(t *testing.T) {
+		mb := testMutableStateBuilder(t)
+		result := mb.IsSignalRequested(requestID)
+		assert.False(t, result)
+	})
+	t.Run("signal found", func(t *testing.T) {
+		mb := testMutableStateBuilder(t)
+		mb.pendingSignalRequestedIDs[requestID] = struct{}{}
+		result := mb.IsSignalRequested(requestID)
+		assert.True(t, result)
+	})
+}
+
+func Test__GetSignalInfo(t *testing.T) {
+	initiatedEventID := int64(1)
+	info := &persistence.SignalInfo{
+		InitiatedID:     1,
+		SignalRequestID: "101",
+	}
+	t.Run("signal not found", func(t *testing.T) {
+		mb := testMutableStateBuilder(t)
+		_, ok := mb.GetSignalInfo(initiatedEventID)
+		assert.False(t, ok)
+	})
+	t.Run("signal found", func(t *testing.T) {
+		mb := testMutableStateBuilder(t)
+		mb.pendingSignalInfoIDs[initiatedEventID] = info
+		result, ok := mb.GetSignalInfo(initiatedEventID)
+		assert.True(t, ok)
+		assert.Equal(t, info, result)
+	})
+}
+
+func Test__ReplicateExternalWorkflowExecutionSignaled(t *testing.T) {
+	mb := testMutableStateBuilder(t)
+	event := &types.HistoryEvent{
+		ExternalWorkflowExecutionSignaledEventAttributes: &types.ExternalWorkflowExecutionSignaledEventAttributes{
+			InitiatedEventID: 1,
+		},
+	}
+	info := &persistence.SignalInfo{
+		InitiatedID:     1,
+		SignalRequestID: "101",
+	}
+	mb.pendingSignalInfoIDs[int64(1)] = info
+	mb.updateSignalInfos[int64(1)] = info
+	err := mb.ReplicateExternalWorkflowExecutionSignaled(event)
+	assert.NoError(t, err)
+	assert.NotNil(t, mb.deleteSignalInfos[int64(1)])
+	_, ok := mb.pendingSignalInfoIDs[int64(1)]
+	assert.False(t, ok)
+	_, ok = mb.updateSignalInfos[int64(1)]
+	assert.False(t, ok)
+}
+
+func Test__ReplicateSignalExternalWorkflowExecutionFailedEvent(t *testing.T) {
+	mb := testMutableStateBuilder(t)
+	event := &types.HistoryEvent{
+		SignalExternalWorkflowExecutionFailedEventAttributes: &types.SignalExternalWorkflowExecutionFailedEventAttributes{
+			InitiatedEventID: 1,
+		},
+	}
+	info := &persistence.SignalInfo{
+		InitiatedID:     1,
+		SignalRequestID: "101",
+	}
+	mb.pendingSignalInfoIDs[int64(1)] = info
+	mb.updateSignalInfos[int64(1)] = info
+	err := mb.ReplicateSignalExternalWorkflowExecutionFailedEvent(event)
+	assert.NoError(t, err)
+	assert.NotNil(t, mb.deleteSignalInfos[int64(1)])
+	_, ok := mb.pendingSignalInfoIDs[int64(1)]
+	assert.False(t, ok)
+	_, ok = mb.updateSignalInfos[int64(1)]
+	assert.False(t, ok)
+}
+
+func Test__AddSignalRequested(t *testing.T) {
+	mb := testMutableStateBuilder(t)
+	requestID := "101"
+	mb.pendingSignalRequestedIDs = nil
+	mb.updateSignalRequestedIDs = nil
+	mb.AddSignalRequested(requestID)
+	assert.NotNil(t, mb.pendingSignalRequestedIDs[requestID])
+	assert.NotNil(t, mb.updateSignalRequestedIDs[requestID])
+}
+
+func Test__DeleteSignalRequested(t *testing.T) {
+	mb := testMutableStateBuilder(t)
+	requestID := "101"
+	mb.pendingSignalRequestedIDs[requestID] = struct{}{}
+	mb.updateSignalRequestedIDs[requestID] = struct{}{}
+	mb.DeleteSignalRequested(requestID)
+	assert.NotNil(t, mb.deleteSignalRequestedIDs[requestID])
+}
+
+func Test__AddExternalWorkflowExecutionSignaled(t *testing.T) {
+	t.Run("error workflow finished", func(t *testing.T) {
+		mbCompleted := testMutableStateBuilder(t)
+		mbCompleted.executionInfo.State = persistence.WorkflowStateCompleted
+		_, err := mbCompleted.AddExternalWorkflowExecutionSignaled(1, "test-domain", "wid", "rid", []byte{10})
+		assert.Error(t, err)
+		assert.Equal(t, ErrWorkflowFinished, err)
+	})
+	t.Run("error getting signal info", func(t *testing.T) {
+		mb := testMutableStateBuilder(t)
+		_, err := mb.AddExternalWorkflowExecutionSignaled(1, "test-domain", "wid", "rid", []byte{10})
+		assert.Error(t, err)
+		assert.Equal(t, "add-externalworkflow-signal-requested-event operation failed", err.Error())
+	})
+	t.Run("success", func(t *testing.T) {
+		mb := testMutableStateBuilder(t)
+		si := &persistence.SignalInfo{
+			InitiatedID: 1,
+		}
+		mb.pendingSignalInfoIDs[1] = si
+		mb.hBuilder = NewHistoryBuilder(mb)
+		event, err := mb.AddExternalWorkflowExecutionSignaled(1, "test-domain", "wid", "rid", []byte{10})
+		assert.NoError(t, err)
+		assert.Equal(t, int64(1), event.ExternalWorkflowExecutionSignaledEventAttributes.GetInitiatedEventID())
+	})
+}
+
+func Test__AddSignalExternalWorkflowExecutionFailedEvent(t *testing.T) {
+	t.Run("error workflow finished", func(t *testing.T) {
+		mbCompleted := testMutableStateBuilder(t)
+		mbCompleted.executionInfo.State = persistence.WorkflowStateCompleted
+		_, err := mbCompleted.AddSignalExternalWorkflowExecutionFailedEvent(1, 1, "test-domain", "wid", "rid", []byte{10}, types.SignalExternalWorkflowExecutionFailedCauseWorkflowAlreadyCompleted)
+		assert.Error(t, err)
+		assert.Equal(t, ErrWorkflowFinished, err)
+	})
+	t.Run("error getting signal info", func(t *testing.T) {
+		mb := testMutableStateBuilder(t)
+		_, err := mb.AddSignalExternalWorkflowExecutionFailedEvent(1, 1, "test-domain", "wid", "rid", []byte{10}, types.SignalExternalWorkflowExecutionFailedCauseWorkflowAlreadyCompleted)
+		assert.Error(t, err)
+		assert.Equal(t, "add-externalworkflow-signal-failed-event operation failed", err.Error())
+	})
+	t.Run("success", func(t *testing.T) {
+		mb := testMutableStateBuilder(t)
+		si := &persistence.SignalInfo{
+			InitiatedID: 1,
+		}
+		mb.pendingSignalInfoIDs[1] = si
+		mb.hBuilder = NewHistoryBuilder(mb)
+		event, err := mb.AddSignalExternalWorkflowExecutionFailedEvent(1, 1, "test-domain", "wid", "rid", []byte{10}, types.SignalExternalWorkflowExecutionFailedCauseWorkflowAlreadyCompleted)
+		assert.NoError(t, err)
+		assert.Equal(t, int64(1), event.SignalExternalWorkflowExecutionFailedEventAttributes.GetInitiatedEventID())
+	})
+}
+
+func Test__AddSignalExternalWorkflowExecutionInitiatedEvent(t *testing.T) {
+	request := &types.SignalExternalWorkflowExecutionDecisionAttributes{
+		Domain: constants.TestDomainName,
+		Execution: &types.WorkflowExecution{
+			WorkflowID: "wid",
+			RunID:      "rid",
+		},
+		SignalName: "test-signal",
+		Input:      make([]byte, 0),
+	}
+	t.Run("error workflow finished", func(t *testing.T) {
+		mbCompleted := testMutableStateBuilder(t)
+		mbCompleted.executionInfo.State = persistence.WorkflowStateCompleted
+		_, _, err := mbCompleted.AddSignalExternalWorkflowExecutionInitiatedEvent(1, "101", request)
+		assert.Error(t, err)
+		assert.Equal(t, ErrWorkflowFinished, err)
+	})
+	t.Run("success", func(t *testing.T) {
+		mb := testMutableStateBuilder(t)
+		mb.executionInfo = &persistence.WorkflowExecutionInfo{
+			DomainID:   constants.TestDomainID,
+			WorkflowID: "wid",
+			RunID:      "rid",
+		}
+		mb.hBuilder = NewHistoryBuilder(mb)
+		event, si, err := mb.AddSignalExternalWorkflowExecutionInitiatedEvent(1, "101", request)
+		assert.NoError(t, err)
+		assert.Equal(t, request.Execution, event.SignalExternalWorkflowExecutionInitiatedEventAttributes.GetWorkflowExecution())
+		assert.Equal(t, "101", si.SignalRequestID)
+	})
+}