Disable callbacks when extension is disabled #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adieyal
changed the title
akx
reviewed
Nov 6, 2023
|
and keep the module name the same? |
adieyal
force-pushed
the
bug/initialize-properties-before-exit
branch
from
29d47bc
to
5ef7740
Compare
|
Now that I think of it, I'm not sure the protocol is actually required at all – couldn't we just use the actual script object as a type (guarded against circular imports)? |
Happy to do that too. I'll make the change. |
Ensure that callbacks (apart from settings and wildcards manager), only run when dynamic prompts is enabled. This builds on #648
adieyal
force-pushed
the
bug/initialize-properties-before-exit
branch
from
5ef7740
to
6b5016c
Compare
akx
requested changes
Nov 12, 2023
| from sd_dynamic_prompts.settings import on_ui_settings | ||
| from sd_dynamic_prompts.wildcards_tab import initialize as initialize_wildcards_tab | ||
|
|
||
| if TYPE_CHECKING: | ||
| from sd_dynamic_prompts.sddp_script import SDDPScript |
There was a problem hiding this comment.
Suggested change
| from sd_dynamic_prompts.sddp_script import SDDPScript | |
| from sd_dynamic_prompts.dynamic_prompting import Script as SDDPScript |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that callbacks (apart from settings and wildcards manager), only run when dynamic prompts is enabled. This builds on #648