Skip to content

Conversation

@c0rydoras
Copy link
Collaborator

No description provided.

@c0rydoras c0rydoras added backend This issue or pull request is backend related enhancement This issue or pull request discusses non feature changes labels Aug 28, 2023
@c0rydoras c0rydoras self-assigned this Aug 28, 2023
@c0rydoras c0rydoras linked an issue Aug 28, 2023 that may be closed by this pull request
@c0rydoras c0rydoras force-pushed the django-base-project-command branch from 19bbf4d to cbd70e3 Compare August 28, 2023 12:47
@c0rydoras c0rydoras requested a review from open-dynaMIX August 28, 2023 12:59
@c0rydoras c0rydoras force-pushed the django-base-project-command branch 3 times, most recently from f44333f to 02ec3f6 Compare September 5, 2023 09:16
@c0rydoras c0rydoras force-pushed the django-base-project-command branch from 02ec3f6 to 0be0163 Compare October 4, 2023 12:27
@c0rydoras c0rydoras force-pushed the django-base-project-command branch from 0be0163 to 2b26d7a Compare October 24, 2023 11:39
@c0rydoras c0rydoras force-pushed the django-base-project-command branch 4 times, most recently from cc75a69 to 6033236 Compare October 30, 2023 09:54
Copy link
Member

@open-dynaMIX open-dynaMIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

Regarding commit names, it would be nice if they would more reflect a reasoning. For example the commit refacor(api): drop async in synchronizer: When reading the code change it's clear what was done. What's unclear is why was it done.

@c0rydoras c0rydoras force-pushed the django-base-project-command branch 2 times, most recently from 4c6e7b7 to 07a7879 Compare October 30, 2023 11:30
@c0rydoras c0rydoras force-pushed the django-base-project-command branch 3 times, most recently from fc22aac to 1ce83b6 Compare October 30, 2023 11:42
@c0rydoras c0rydoras force-pushed the django-base-project-command branch from 1ce83b6 to 6ebc920 Compare October 30, 2023 12:12
@c0rydoras c0rydoras force-pushed the django-base-project-command branch from 6ebc920 to fc2df91 Compare October 30, 2023 12:26
@c0rydoras c0rydoras merged commit f6c1fc3 into adfinis:main Oct 30, 2023
@c0rydoras c0rydoras deleted the django-base-project-command branch October 30, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend This issue or pull request is backend related enhancement This issue or pull request discusses non feature changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Project Base Management Command

2 participants