Switch testing from a shell script to spec #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
adetokunbo
commented
Mar 16, 2019
adetokunbo
commented
- Added a new sub package just for testing
- the subpackage takes the built executable as a build dependency and runs the tests
A new test project is required. The tests need to make use of the executable build by the main project. With just cabal, this is possible using a test-target inside the same project via referring to the executable using build-depends However, normally, nix won't install the built executable until the tests for the project have run, so nix builds will not work.
The haskell unittest has a big difference from the shell test - instead of actually building the derivation, it parses it and checks that its input derivations are as expected, as this is much quicker.
- also: print a deprecation warning instead of running test.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.