Skip to content

Conversation

manuelprinz
Copy link

The Kotlin version used to build the project is included in the JAR and
causes downstream projects to fail to compile. When removing the dependency
the tester module needs to provide Kotlin, so a dependency was added.

Closes: #125

The Kotlin version used to build the project is included in the JAR and
causes downstream projects to fail to compile. When removing the dependency
the tester module needs to provide Kotlin, so a dependency was added.

Closes: adessoSE#125
@manuelprinz
Copy link
Author

I am not sure how to best address this in the documentation. It now needs to have a dependency on the Kotlin Standard Library, but I suspect all projects will have that anyway (at least those affected by the issue). Suggestions welcome, I can update accordingly.

@manuelprinz
Copy link
Author

Having a deeper look at the API, the following would properly be a better solution:

api("org.jetbrains.kotlin:kotlin-stdlib")
implementation("org.jetbrains.kotlin:kotlin-reflect")
implementation("com.google.code.gson:gson:2.7")

The project currently only uses one Kotlin-specific class from the standard library in its public API (a constructor marker in the init method of the Event data class). Both the reflection API and GSON are only used internally and implementation details.

This declaration only works with more recent versions of Gradle, though.

@florianluediger
Copy link
Member

Hi Manuel and thank you very much for your interest in the JUnit Insights project. As you probably have noticed, the project is not under active development anymore. I can't really reproduce the issue described in #125 so I do not really know what to do with this PR. If you are confident that you have found a proper solution to the problem, please let me know and I will try to review and merge your contribution.

@manuelprinz
Copy link
Author

Hi Florian, it's been a while, I need to check again. I will get back to you as soon as I can.

@sergeyamaslov
Copy link

sergeyamaslov commented Dec 5, 2021

I can reproduce this one too, though the fix seems not to be working for me

@dhasilin
Copy link

dhasilin commented Mar 6, 2023

@sergeyamaslov have you tried simple exclude:
testCompile ('de.adesso:junit-insights:1.1.0'){ exclude group: 'org.jetbrains.kotlin', module: 'kotlin-reflect' }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests won't run if the plugin is added
4 participants