cleanup: do not dilate the primary purpose of this plugin, extract helpers to a separate repository#14
Conversation
…iases to avoid hardcoding the abstracted plugin IDs
adelinosousa
left a comment
adelinosousa
left a comment
There was a problem hiding this comment.
Not sure I understand why we need these changes. Can you help me see the big picture?
Why would the gh-cli-auth plugin provide management of version catalog aliases? Wouldn't this be better handled in its own or a conventions plugin?
Just want to make sure we don't dilute gh-cli-auth purpose 😉
…ese to a separate repository
@adelinosousa I 100% agree, it's not really related to the CLI auth, I just had similar things pushed here previously when I did the 2.0.0 refactors, but now that I think about it, it should be decoupled, I have pushed cleanup commits to fix this. I got an idea for our team to still use this plugin, yet get the GH auth CLI features as well in a clean way, will ping you about it! |
u-ways-e
changed the title
enable function to apply plugins using version catalog aliases to avoid hardcoding the abstracted plugin IDs
2 participants
Details
I had added some helpers that are not related to the primary functionality of this plugin, let's remove them to keep the single responsibility!