This repository has been archived by the owner on Jul 7, 2020. It is now read-only.
Add Getters for Width and Depth attributes #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudfnr
force-pushed
the
CountMinSketch_Getters
branch
from
66dc702
to
e24cc7e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just want to add getters on Depth and Width attributes in Count-Min Sketch.
It will allow to optimize serialization by pre-computing the number of bytes required in the process.
I thinks it is more convenient than getting the relative error and epsilon attributes and then converting them into depth and width because it adds some useless computations.