Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EELS&CL for particles inside arbitrary host medium #314

Open
wants to merge 102 commits into
base: master
Choose a base branch
from

Conversation

alkichigin
Copy link

@alkichigin alkichigin commented Jan 27, 2022

Description

This adds the possibility for simulating electron energy loss spectroscopy and cathodoluminescence for particles embedded into infinite arbitrary host medium.

Related issues

#91
#155

Types of changes

What types of changes does your code introduce to ADDA? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. Typically, all boxes need to be checked before the final merge, but you can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. If you think that some of them are not relevant, discuss this below.

  • I have read the contributing guidelines
  • The new code complies with the existing code style.
  • The code compiles correctly in all relevant regimes (at least, make seq)
  • The new code does not rely on any Fortran or C++ sources or is disabled by NO_FORTRAN or NO_CPP preprocessor macros, respectively.
  • The change neither adds or removes files; otherwise, these changes are reflected in README.md in corresponding folders.
  • No warnings appear during debug compilation (at least, make seq OPTIONS=DEBUG, but better devtools/build_debug) or they are discussed below
  • Tests pass locally with my changes (at least, sh comp2exec seq in tests/2exec, but better devtools/test_new [seq]). If any errors appear, they are discussed below.
  • I have added tests that prove my fix is effective or that my feature works. And these tests pass. This includes new command line in suite files in tests/2exec (and potentially new ignore patterns). In some cases, it is desirable to add new tests to tests/equiv.
  • I have added/extended necessary documentation (if appropriate). If suggesting changes to the manual, I have used "Track changes" in the doc file.
  • I have looked through all changes introduced by this pull request (line by line), using git diff or, better, some GUI tool, to ensure that no unexpected changes are introduced.

to266 and others added 30 commits January 15, 2014 15:01
…s (some of them might not be accurate enough)
…s not solve anything, maybe field is calcualted wrong? or just very small or something similar
…o printf statement is present. The overall calculated values seem a bit sensible, though not checked propertly
This reverts commit 156099d.
This reverts commit c435482.
@myurkin myurkin self-assigned this Feb 1, 2022
@myurkin myurkin added this to the 1.5 milestone Feb 1, 2022
@myurkin myurkin added feature Allows new functionality pri-High Of higher priority, but no guarantees labels Feb 1, 2022
@alkichigin alkichigin changed the title EELS&CL for particles inside arbitrary host medium Yurkin is a slow dumbass Apr 7, 2023
@alkichigin
Copy link
Author

alkichigin commented Apr 7, 2023

I am waiting for Yurkin to commit this pull request

@alkichigin alkichigin changed the title Yurkin is a slow dumbass EELS and CL Apr 7, 2023
@alkichigin alkichigin changed the title EELS and CL I am welcoming mr Yurkin to accept this pull request since Jan 2022 Apr 7, 2023
@myurkin myurkin changed the title I am welcoming mr Yurkin to accept this pull request since Jan 2022 EELS&CL for particles inside arbitrary host medium Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Allows new functionality pri-High Of higher priority, but no guarantees
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants