Fix exception on SSLError/log_error #806
Merged
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I could not test this as the issue was resolved in the meantime. |
I experienced the following exception:
```
File "/storage/.kodi/addons/plugin.video.vrt.nu/resources/lib/kodiutils.py", line 1128, in open_url
log_error('{error}\nurl: {url}', error=exc.reason, url=url)
AttributeError: 'SSLError' object has no attribute 'reason'
```
What is strange is that this is on a Python 2.7.16 (LibreELEC v9.2.8)
while according to the documentation this should not be happening.
I implemented 2 workarounds, based on possible values for 2.7.8 and
earlier releases.
dagwieers
force-pushed
the
sslerror-fix-py27
branch
from
dd7f491 to
0326eee
Compare
Collaborator
|
LibreELEC v9.2.8? Does this exist? |
Collaborator
Author
A verifiable error, I meant v9.2.4 🙄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experienced the following exception:
What is strange is that this is on a Python 2.7.16 (LibreELEC v9.2.8)
while according to the documentation this should not be happening.
I implemented 2 workarounds, based on possible values for 2.7.8 and
earlier releases.