Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XPaths: improve accuracy for major news outlets #530

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Conversation

adbar
Copy link
Owner

@adbar adbar commented Mar 27, 2024

This PR improves the accuracy of main content detection (especially before and after the actual content) for the following websites:

  • AP News
  • Free Beacon
  • LA Times
  • Reuters
  • Washington Times

Credit to fundus-evaluation for evaluating the software and providing a benchmark.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (fa972ab) to head (fdf1f2f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #530   +/-   ##
=======================================
  Coverage   97.35%   97.35%           
=======================================
  Files          22       22           
  Lines        3439     3439           
=======================================
  Hits         3348     3348           
  Misses         91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adbar
Copy link
Owner Author

adbar commented Mar 28, 2024

@felipehertzer I'm leaving this PR open for now, if you want to have a look or add something feel free to do so.

@felipehertzer
Copy link
Contributor

Hey @adbar, I will have a look this week, the changes makes sense.

But, I have two websites from the last pull request that I couldn't find a way to fix it.

Both are getting more text that should be. If you want to have a look:
Website 1

Website 2

@adbar
Copy link
Owner Author

adbar commented Apr 3, 2024

@felipehertzer The first extracts too much content indeed but the second works nearly OK.

I'll merge the PR now as I'll release a new version shortly but you can have a look at it later and suggest improvements if you find something. The benchmark above is also interesting.

@adbar adbar merged commit d288fcc into master Apr 3, 2024
16 checks passed
@adbar adbar deleted the better_xpaths branch April 3, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants