Move drag handle outside the cell #3334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3334 +/- ##
==========================================
- Coverage 83.38% 83.09% -0.30%
==========================================
Files 47 47
Lines 4910 4932 +22
Branches 752 757 +5
==========================================
+ Hits 4094 4098 +4
- Misses 816 834 +18
|
amanmahajan7
commented
Sep 5, 2023
src/DragHandle.tsx
Outdated
| gridColumnStart: column.idx + 1, | ||
| gridRowStart, | ||
| insetInlineStart: | ||
| column.frozen && typeof column.width === 'number' |
There was a problem hiding this comment.
Not sure if this can cause any issues
nstepien
reviewed
Sep 6, 2023
| function getDragHandle(rowIdx: number) { | ||
| if (selectedPosition.rowIdx !== rowIdx || selectedPosition.mode === 'EDIT' || onFill == null) { | ||
| function renderDragHandle() { | ||
| if ( |
There was a problem hiding this comment.
Do we need to check whether the selected cell is not in a summary row?
There was a problem hiding this comment.
isCellWithinViewportBounds would return false for header and summary rows. There is another function isCellWithinSelectionBounds that can be used to check header and summary rows as well
Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
nstepien
approved these changes
Sep 6, 2023
adityatoshniwal
pushed a commit
to pgadmin-org/react-data-grid
that referenced
this pull request
Jul 31, 2024
* Move drag handle outside the cell * alternate approach * revert * Remove margin * Fix drag handle position on frozen column * Fix typo * Fix colSpan * Simplify styles * Update src/DragHandle.tsx Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com> * Update src/DataGrid.tsx Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com> * Fix if condition --------- Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pros:
Cons