Handle column sorting events directly on the header cell #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstepien
commented
Aug 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #3316 +/- ##
==========================================
+ Coverage 83.54% 83.75% +0.21%
==========================================
Files 45 45
Lines 4588 4568 -20
Branches 719 717 -2
==========================================
- Hits 3833 3826 -7
+ Misses 755 742 -13
|
src/HeaderCell.tsx
Outdated
|
|
||
| if (offset > 11) { | ||
| // +1px to account for the border size | ||
| return; | ||
| } | ||
|
|
||
| // prevent selecting/sorting if we started resizing the column, including double-clicking | ||
| ignoreClickRef.current = true; |
There was a problem hiding this comment.
We do not use a ref currently. Is there a bug?
There was a problem hiding this comment.
Without it, after resizing the column, the click event is triggered on the header cell.
This wasn't an issue before as the click event handler was on a child element
amanmahajan7
previously approved these changes
Aug 22, 2023
amanmahajan7
approved these changes
Aug 22, 2023
adityatoshniwal
pushed a commit
to pgadmin-org/react-data-grid
that referenced
this pull request
Jul 31, 2024
* Handle column sorting events directly on the header cell * fix main styles * add resize handler element * rm newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.