typescript-eslint@6.1.0
#3288
Merged
typescript-eslint@6.1.0
#3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nstepien
commented
Jul 19, 2023
•
nstepien
commented
- https://main--typescript-eslint.netlify.app/blog/announcing-typescript-eslint-v6/
- https://github.com/typescript-eslint/typescript-eslint/blob/main/CHANGELOG.md
- https://typescript-eslint.io/rules/prefer-nullish-coalescing/
src/hooks/useCalculatedColumns.ts
Outdated
| @@ -51,7 +51,6 @@ export function useCalculatedColumns<R, SR>({ | |||
| let lastFrozenColumnIndex = -1; | |||
|
|
|||
| const columns = rawColumns.map((rawColumn) => { | |||
| // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing | |||
| const frozen = rawColumn.frozen || false; | |||
There was a problem hiding this comment.
Why do we not use rawColumn.frozen ?? false;?
There was a problem hiding this comment.
You're right, we can safely use ?? here
amanmahajan7
approved these changes
Jul 19, 2023
adityatoshniwal
pushed a commit
to pgadmin-org/react-data-grid
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.