Skip to content

Hotfix/v1.1.1#381

Merged
darylhedley merged 4 commits into
masterfrom
hotfix/v1.1.1
Jun 5, 2014
Merged

Hotfix/v1.1.1#381
darylhedley merged 4 commits into
masterfrom
hotfix/v1.1.1

Conversation

@darylhedley

@darylhedley darylhedley commented Jun 4, 2014

Copy link
Copy Markdown
Contributor

Fixes internal router, model, load order and questionView bugs

fixes #380
fixes #379
fixes #377
fixes #376
fixes #374

@darylhedley
Bug fixes
cef896b 
- Fixes adapt.json getting latest components
- Fixes the _isAvailable completion and ready
- Fixes to location class added to #wrapper tag
- Fixes to questionView with feedback titles
@darylhedley
Bug fixes
97b8286 
- Fixed load order bug
- Remove unnecessary event removals
- Removed un-used init method
- Made check for dataLoaded more robust
@darylhedley
Fixed tests
ed2bc9f
@kevincorry

kevincorry commented Jun 4, 2014

Copy link
Copy Markdown
Contributor

Looks good +1

@kineogavin

kineogavin commented Jun 4, 2014

Copy link
Copy Markdown
Contributor

+1 for the load order fix...but should line 52 in app.js
Adapt.off('adaptCollection:dataLoaded configModel:dataLoaded');
not be...
Adapt.off('adaptCollection:dataLoaded courseModel:dataLoaded');
?

@darylhedley

darylhedley commented Jun 4, 2014

Copy link
Copy Markdown
Contributor Author

Good spot!

darylhedley added a commit that referenced this pull request Jun 5, 2014
@darylhedley
Merge pull request #381 from adaptlearning/hotfix/v1.1.1
ec9f0b8 
Hotfix/v1.1.1
@darylhedley
darylhedley merged commit ec9f0b8 into master Jun 5, 2014
@darylhedley
darylhedley deleted the hotfix/v1.1.1 branch June 5, 2014 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

4 participants

@darylhedley @kevincorry @kineogavin @zenduo