allow correct answer/hide correct answer buttons to be keyboard/screen reader accessible #3051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Q/GMCQ that use itemsQuestionModel.js
remove unused parameters from updateAttemptsCount
oliverfoster
approved these changes
Mar 3, 2021
Contributor
Author
|
should also resolve #2961 |
Contributor
Author
|
Sample course: Notes:
|
eleanor-heath
approved these changes
Mar 4, 2021
tomgreenfield
approved these changes
Mar 12, 2021
| } else { | ||
| ariaAnswer = globals.ariaCorrectAnswers; | ||
| const correctOptions = this.getChildren().where({ _shouldBeSelected: true }); | ||
| correctAnswer = correctOptions.map(correctOption => correctOption.get('text')).join('<br>'); |
Contributor
There was a problem hiding this comment.
As discussed, could always pass through the correct answers as an array, giving flexibility to the plugin globals:
Don't know if it will ever be tweaked in practice.
Contributor
Author
There was a problem hiding this comment.
It's a nice suggestion but as you say, whether it will ever get used in practice is questionable.... can easily be changed in future if it does come up as a requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #2942
Note: will also require updates to all the core question components, these will follow shortlyNow done - except for textInputI'll also try and add a demo build so that anyone wanting to actually test this out can do sodone, see this comment