issue/2363 drop src/course pathway in grunt#2644
Merged
oliverfoster merged 6 commits intorelease/v6from Mar 16, 2020
Merged
Conversation
oliverfoster
commented
Feb 10, 2020
Member
|
Is there any knock-on effect on the Adapt CLI with this change? |
Member
Author
There shouldn't be. I will check. |
Member
Thinking abt those who come new to the project, or who just simply don't take the time to deliberately choose btwn the master and a release: can you avoid some questions/problems/explanations by using a v6 branch? (no strong opinion myself) |
brian-learningpool
approved these changes
Feb 19, 2020
lc-alexanderbenesch
approved these changes
Mar 3, 2020
lc-alexanderbenesch
left a comment
There was a problem hiding this comment.
Looks good, works even better 👌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2363
build/courseor suppliedoutputdirfolder only, nosrc/courseserver-buildbuild:diffanddev:diffas options during refactorsrc/coursefolder, removed pathways for processingbuild/coursefolder, .gitignore and copy task directivesgrunt cleanworks correctlybuild/course - course content
src - plugins only
src/course - deleted
IMPORTANT:
This will break AAT import and export as they expect src/course.
It will not break the framework but is a sufficiently large change to warrant a major version number.
QUESTION:
Process - Do we need a separate branch for v6 (as with v5) or merge straight into master?Yes.