-
Notifications
You must be signed in to change notification settings - Fork 66
issue/3177 column structure #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0837dc8
Initial columns set up
guywillis 0b389fd
Merge branch 'master' into issue/3177
guywillis 6d1b011
Columns refactored
guywillis 8cd7b75
Component header bg mixin
guywillis e3c3e5a
Indentation amends
guywillis 7528ffc
Merge branch 'master' into issue/3177
guywillis a8d1744
Merge branch 'master' into issue/3177
guywillis 420f7b6
Removed component header mixin, removed indentation
guywillis 12fc6e5
Revert padding amends
guywillis b9eb387
Indentation amend
guywillis e4312c7
Columns added to example.json
guywillis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| .make-columns(@size, @media-query, @count, @iteration: 1) when (@count >= @iteration) { | ||
| @media (min-width: @media-query) { | ||
| .component.col-@{size}-@{iteration} { | ||
| width: (@iteration * 100% / @count); | ||
| } | ||
| } | ||
|
|
||
| .make-columns(@size, @media-query, @count, (@iteration + 1)); | ||
| } | ||
|
|
||
| // Custom classes | ||
| // e.g. 'col-sm-8 col-md-10' | ||
| // min small viewport takes up 8 out of 12 columns | ||
| // min medium viewport takes up 10 columns | ||
| // if undefined element defaults to 100% width | ||
| .make-columns(xs, 0, 12); | ||
| .make-columns(sm, @device-width-small, 12); | ||
| .make-columns(md, @device-width-medium, 12); | ||
| .make-columns(lg, @device-width-large, 12); | ||
| .make-columns(xl, @max-width, 12); | ||
|
|
||
| .component { | ||
| &__container { | ||
| flex-direction: unset; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.