Skip to content

Update: Switch to model.getFeedback allowing more complex feedback objects#79

Merged
oliverfoster merged 2 commits intomasterfrom
issue/222
Sep 6, 2022
Merged

Update: Switch to model.getFeedback allowing more complex feedback objects#79
oliverfoster merged 2 commits intomasterfrom
issue/222

Conversation

@oliverfoster
Copy link
Copy Markdown
Member

@oliverfoster oliverfoster commented Aug 17, 2022 •
edited
Loading

fixes adaptlearning/adapt-contrib-core#222

Update

  • Switch to new getFeedback function to allow passing images through to the notify

Requires ref adaptlearning/adapt-contrib-core#223

Todo

  • Framework bump on release of associated core pr

@oliverfoster oliverfoster self-assigned this Aug 17, 2022
@oliverfoster oliverfoster mentioned this pull request Aug 17, 2022
Merged
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Aug 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 25fe47c into master Sep 6, 2022
@oliverfoster oliverfoster deleted the issue/222 branch September 6, 2022 09:29
github-actions bot pushed a commit that referenced this pull request Sep 6, 2022
@semantic-release-bot
Chore(release): 4.4.0 [skip ci]
2ab455e 
# [4.4.0](v4.3.0...v4.4.0) (2022-09-06)

### Update

* Switch to model.getFeedback allowing more complex feedback objects (#79) ([25fe47c](25fe47c)), closes [#79](#79)
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 6, 2022

🎉 This PR is included in version 4.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to nagyist/adapt-contrib-tutor that referenced this pull request May 27, 2023
@semantic-release-bot
Chore(release): 2.2.0 [skip ci]
7679d6a 
# [2.2.0](v2.1.2...v2.2.0) (2023-05-27)

### chore

* added package.json ([677347b](677347b))
* added package.json ([94afb62](94afb62)), closes [#3072](https://github.com/nagyist/adapt-contrib-tutor/issues/3072)

### Fix

* _globals schema nesting (adaptlearning#90) ([c385e3c](c385e3c)), closes [adaptlearning#90](https://github.com/nagyist/adapt-contrib-tutor/issues/90)
* Added gitignore for release automation (adaptlearning#77) ([bef3c93](bef3c93)), closes [adaptlearning#77](https://github.com/nagyist/adapt-contrib-tutor/issues/77)
* Added release automation (adaptlearning#73) ([c04b610](c04b610)), closes [adaptlearning#73](https://github.com/nagyist/adapt-contrib-tutor/issues/73)
* Bump http-cache-semantics from 4.1.0 to 4.1.1 (adaptlearning#82) ([076e8c5](076e8c5)), closes [adaptlearning#82](https://github.com/nagyist/adapt-contrib-tutor/issues/82)
* Check tutor type on page revisit before displaying inline feedback (fixes adaptlearning#91) (adaptlearning#92) ([e4f5761](e4f5761)), closes [adaptlearning#91](https://github.com/nagyist/adapt-contrib-tutor/issues/91) [adaptlearning#92](https://github.com/nagyist/adapt-contrib-tutor/issues/92)
* Framework bumped to v5.22.8 ([8a17aae](8a17aae))
* Inline feedback normalisation across course and component config (fixes adaptlearning#87) (adaptlearning#88) ([f03b1ee](f03b1ee)), closes [adaptlearning#87](https://github.com/nagyist/adapt-contrib-tutor/issues/87) [adaptlearning#88](https://github.com/nagyist/adapt-contrib-tutor/issues/88)
* New style schema added. (adaptlearning#84) ([5be15e0](5be15e0)), closes [adaptlearning#84](https://github.com/nagyist/adapt-contrib-tutor/issues/84)
* Normalizing template icons ([cff3c07](cff3c07))
* replace deprecated a11y_attrs_heading usage (refs adaptlearning#67) (adaptlearning#76) ([f34b5fa](f34b5fa)), closes [adaptlearning#67](https://github.com/nagyist/adapt-contrib-tutor/issues/67) [adaptlearning#76](https://github.com/nagyist/adapt-contrib-tutor/issues/76)
* Stop _id property from directly rendering the _id view (adaptlearning#78) ([df1da66](df1da66)), closes [adaptlearning#78](https://github.com/nagyist/adapt-contrib-tutor/issues/78)
* Version numbers removed from Readme files ([7b6f5bd](7b6f5bd))

### New

* Issue and pr project addition automation (Fixes #3315) ([46f531d](46f531d)), closes [#3315](https://github.com/nagyist/adapt-contrib-tutor/issues/3315)
* Issue and pr project addition automation (refs adaptlearning/adapt_framework#3315) ([a666b69](a666b69))

### Update

* `"inline"` feedback restoration (adaptlearning#81) ([f5f35a2](f5f35a2)), closes [adaptlearning#81](https://github.com/nagyist/adapt-contrib-tutor/issues/81)
* Add accessible title (refs adaptlearning#74) (adaptlearning#75) ([bbe81f6](bbe81f6)), closes [adaptlearning#74](https://github.com/nagyist/adapt-contrib-tutor/issues/74) [adaptlearning#75](https://github.com/nagyist/adapt-contrib-tutor/issues/75)
* Switch to model.getFeedback allowing more complex feedback objects (adaptlearning#79) ([25fe47c](25fe47c)), closes [adaptlearning#79](https://github.com/nagyist/adapt-contrib-tutor/issues/79)

### Upgrade

* Bump yaml and semantic-release (adaptlearning#93) ([723a352](723a352)), closes [adaptlearning#93](https://github.com/nagyist/adapt-contrib-tutor/issues/93)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethan-lp ethan-lp ethan-lp approved these changes

@eleanor-heath eleanor-heath eleanor-heath approved these changes

+1 more reviewer

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@oliverfoster oliverfoster

Labels

enhancement released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature request: Feedback image and generic text

4 participants

@oliverfoster @cahirodoherty-learningpool @ethan-lp @eleanor-heath