Draft
Conversation
chris-steele
requested review from
cahirodoherty-learningpool and
eleanor-heath
Contributor
Author
|
@cahirodoherty-learningpool, @oliverfoster, @swashbuck, @eleanor-heath I've added some more tests and reduced the amount of mocking. To date there is coverage for models, controller and TrickleButtonModel. My approach is to treat these modules as the units under test. Therefore I have mocked imports as appropriate, e.g. the controller test spec mocks the functions it imports from models etc. I'd appreciate any reviews/feedback, particularly if you have strong inclinations about where the boundaries of the 'units' should lie and thoughts on mocking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @eleanor-heath, @cahirodoherty-learningpool - not sure if you are still involved with the formal testing work, but if you are and have time, I'd appreciate your thoughts on this PR. It is just a WIP at the moment. I've added some unit tests for trickle and hope to expand it out in due course.