Skip to content

Fix: role added to component__widget div (fixes #145) #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joe-allen-89 merged 1 commit into from
Jul 29, 2024
Merged

Fix: role added to component__widget div (fixes #145) #146

joe-allen-89 merged 1 commit into from
Jul 29, 2024

Conversation

@joe-allen-89
Copy link
Contributor

@joe-allen-89 joe-allen-89 commented Jul 11, 2024 •
edited by oliverfoster
Loading

@joe-allen-89 joe-allen-89 self-assigned this Jul 11, 2024
@joe-allen-89 joe-allen-89 linked an issue Jul 11, 2024 that may be closed by this pull request
aria-labelledby/label not being announced when tabbing through. #145
Closed
oliverfoster
oliverfoster reviewed Jul 15, 2024
View reviewed changes
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected when testing with VoiceOver on Mac 👍

@joe-allen-89 joe-allen-89 merged commit 53c8f5d into master Jul 29, 2024
@joe-allen-89 joe-allen-89 deleted the issue/145 branch July 29, 2024 10:07
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
@semantic-release-bot
Chore(release): 7.2.11 [skip ci]
d7a9385 
## [7.2.11](v7.2.10...v7.2.11) (2024-07-29)

### Fix

* role added to component__widget div (fixes #145) (#146) ([53c8f5d](53c8f5d)), closes [#145](#145) [#146](#146)
@github-actions
Copy link

github-actions bot commented Jul 29, 2024

🎉 This PR is included in version 7.2.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@joe-allen-89 joe-allen-89

Labels

accessibility bug released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aria-labelledby/label not being announced when tabbing through.

5 participants

@joe-allen-89 @kirsty-hames @oliverfoster @cahirodoherty-learningpool