Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON schema #11

Merged
merged 5 commits into from
Apr 29, 2014
Merged

JSON schema #11

merged 5 commits into from
Apr 29, 2014

Conversation

dancgray
Copy link
Member

@dancgray dancgray commented Apr 4, 2014

Added JSON schema and added values to bower.json: displayName and component

@dennis-learningpool
Copy link
Member

👍

@brian-learningpool
Copy link
Member

+1

@@ -1,12 +1,15 @@
{
"name": "adapt-contrib-slider",
"version": "0.0.1",
"version": "0.0.2",
"homepage": "https://github.com/adaptlearning/adapt-contrib-slider",
"authors": [
"Daryl Hedley <darylhedley@hotmail.com>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a comma here

@dancgray
Copy link
Member Author

dancgray commented Apr 4, 2014

Added require: true for top and bottom. _correctAnswer is probably redundant in this component.

@zenduo
Copy link
Contributor

zenduo commented Apr 29, 2014

+1

darylhedley added a commit that referenced this pull request Apr 29, 2014
@darylhedley darylhedley merged commit 83ac2b2 into master Apr 29, 2014
@darylhedley darylhedley deleted the json-schema branch April 29, 2014 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants