Fix: find all intersected sets regardless of availablility

[danielghost]

Fixes #19.

Fix

• Find all intersected sets regardless of availablility, when using a modelId - now consistent with other intersection queries
• Allows sets to update to availability changes on their intersections

[oliverfoster]

This begs the question of whether all of the core behaviour should be _isAvailable agnostic and availability should only be checked at the end, i.e. when calculating scores etc. It does seem very weird having a "raw" versions of questions, components, etc rather than an "available" version of questions, components, etc.

The consequence of this PR is that intersection sets will always return the components, questions etc of their this.rawModels only, rather than the components, questions etc of their intersected set models. And therefore all of the score properties will only return the score for this.rawModels, regardless of the intersections. I don't think this is what you intended?

[oliverfoster]

Awaiting response to previous outline of changes

[oliverfoster]

Summary of our conversation offline:

This will break all intersecting subset queries that use createIntersectionSubset. Including getSubsets, getSubsetsByType, getSubsetsByModelId, getSubsetsById, getSubsetsByPath and getSubsetsByQuery. This change will stop the resultant intersecting set from having reduced models. Those functions rely on an unbroken this.filterModels(models) chain, which reduces the models based on this.subsetParent intersections.

As it has been used in production and a version two is on the way imminently, which will fix/revert this change. I will approve to get the changes into the repo history.

[oliverfoster]

With caveats that it will be reverted quickly.

[cahirodoherty-learningpool]

👀

[github-actions]

🎉 This PR is included in version 1.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀