Fix: Added aria-haspopup attribute to nav button (fixes #108)#110
Merged
kirsty-hames merged 2 commits intomasterfrom Jun 4, 2025
Merged
Fix: Added aria-haspopup attribute to nav button (fixes #108)#110kirsty-hames merged 2 commits intomasterfrom
aria-haspopup attribute to nav button (fixes #108)#110kirsty-hames merged 2 commits intomasterfrom
Conversation
guywillis
requested review from
cahirodoherty-learningpool,
kirsty-hames and
oliverfoster
kirsty-hames
reviewed
Jun 4, 2025
oliverfoster
approved these changes
Jun 4, 2025
kirsty-hames
approved these changes
Jun 4, 2025
github-project-automation
bot
moved this from Needs Reviewing
to Recently Released
in adapt_framework: The TODO Board
github-actions bot
pushed a commit
that referenced
this pull request
Jun 4, 2025
## [5.5.4](v5.5.3...v5.5.4) (2025-06-04) ### Chore * Add support for new issue experience (fixes #102) (#105) ([de055b5](de055b5)), closes [#102](#102) [#105](#105) * added note about Spoor dependency (fixes #74) ([4ca6c9d](4ca6c9d)), closes [#74](#74) ### Fix * Added `aria-haspopup` attribute to nav button (fixes #108) (#110) ([26b7903](26b7903)), closes [#108](#108) [#110](#110)
|
🎉 This PR is included in version 5.5.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108
Fix
aria-haspopupattribute to the switch language navigation button with the valuedialog