Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further refactor #421

Merged
merged 6 commits into from
Aug 1, 2023
Merged

Further refactor #421

merged 6 commits into from
Aug 1, 2023

Conversation

oliverfoster
Copy link
Member

Update

  • Removed multiple ternaries
  • Remove switch statement
  • Enclosed new function
  • Removed duplicate behaviour

@oliverfoster oliverfoster added the bug Something isn't working label Aug 1, 2023
@oliverfoster oliverfoster self-assigned this Aug 1, 2023
@oliverfoster oliverfoster mentioned this pull request Aug 1, 2023
Merged
@cahirodoherty-learningpool
Copy link
Contributor

Hi Oliver, I made changes to the base branch while you were working here. Can you resolve conflicts please?

@oliverfoster
Copy link
Member Author

Done

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit c721758 into issue/415 Aug 1, 2023
@oliverfoster oliverfoster deleted the issue/415-b branch August 1, 2023 10:08
cahirodoherty-learningpool added a commit that referenced this pull request Aug 1, 2023
@cahirodoherty-learningpool @oliverfoster
Fix: PartlyCorrect feedback fallback values (#416)
c093556 
* Fix: PartlyCorrect feedback fallback values

* Changing feedback ternery structure for Incorrect

* [WIP] Reducing duplicated code

* Fix: Tidy up of feedback object building

* Adding missing semicolons

* Further refactor (#421)

---------

Co-authored-by: Oliver Foster <oliver.foster@kineo.com>
github-actions bot pushed a commit that referenced this pull request Aug 1, 2023
@semantic-release-bot
Chore(release): 6.38.8
3f9b44d 
## [6.38.8](v6.38.7...v6.38.8) (2023-08-01)

### Fix

* PartlyCorrect feedback fallback values (#416) ([c093556](c093556)), closes [#416](#416) [#421](#421)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverfoster @cahirodoherty-learningpool