Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Added is-prefers-reduced-motion html class and _isPrefersReducedMotionEnabled a11y option #348

Merged
merged 1 commit into from
Apr 18, 2023
Merged

New: Added is-prefers-reduced-motion html class and _isPrefersReducedMotionEnabled a11y option #348

merged 1 commit into from
Apr 18, 2023

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster added enhancement New feature or request accessibility labels Apr 5, 2023
@oliverfoster oliverfoster self-assigned this Apr 5, 2023
@oliverfoster oliverfoster mentioned this pull request Apr 5, 2023
Merged
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 tested with Windows Chrome/Firefox/Edge, all working as expected.

@kirsty-hames kirsty-hames mentioned this pull request Apr 18, 2023
Open
kirsty-hames
kirsty-hames approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Testing on macOS Safari/Chrome/FF and iOS iPhone.

@oliverfoster oliverfoster merged commit 9248e00 into master Apr 18, 2023
@oliverfoster oliverfoster deleted the issue/386-vanilla branch April 18, 2023 15:18
@oliverfoster
Copy link
Member Author

🎉 This PR is included in version 6.31.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Apr 18, 2023
@semantic-release-bot
Chore(release): 6.31.0
7eff5f0 
# [6.31.0](v6.30.6...v6.31.0) (2023-04-18)

### New

* Added is-prefers-reduced-motion html class and _isPrefersReducedMotionEnabled a11y option (#348) ([9248e00](9248e00)), closes [#348](#348)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@oliverfoster oliverfoster

Labels
accessibility enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Accessibility] Animations in theme should use reduced motion media queries
4 participants
@oliverfoster @kirsty-hames @cahirodoherty-learningpool @joe-allen-89