Skip to content

Fix: Add _shouldRenderId to notify api (fixes #208) #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverfoster merged 2 commits into from
Aug 3, 2022
Merged

Fix: Add _shouldRenderId to notify api (fixes #208) #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eed4d1b
Fix: Add _shouldRenderId to notify api (fixes #208)
oliverfoster Aug 2, 2022
6b76374
Fixed expression
oliverfoster Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/views/notifyPopupView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ export default class NotifyPopupView extends Backbone.View {

async addSubView() {
this.subView = this.model.get('_view');
if (this.model.get('_id')) {
if (this.model.get('_shouldRenderId') && this.model.get('_id')) {
// Automatically render the specified id
const model = data.findById(this.model.get('_id'));
const View = components.getViewClass(model);
Expand Down
3 changes: 2 additions & 1 deletion js/views/notifyView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default class NotifyView extends Backbone.View {
get stack() {
return this._stack;
}

get isOpen() {
return (this.stack.length > 0);
}
Expand All @@ -44,6 +44,7 @@ export default class NotifyView extends Backbone.View {
create(notifyObject, defaults) {
notifyObject = _.defaults({}, notifyObject, defaults, {
_type: 'popup',
_shouldRenderId: false,
_isCancellable: true,
_showCloseButton: true,
_closeOnShadowClick: true
Expand Down