Skip to content

Prevent popup from rendering empty .notify__section #476

@kirsty-hames

Description

@kirsty-hames

Subject of the issue

The .notify__section was implemented during a recent PR to expand feedback and add image support. The .notify__section element is rendered regardless if the Notify body or graphic is used. For example, plugins that create their own Notify view such as Hotgraphic.

empty_notify_section

Expected behaviour

Don't render .notify__section unless _graphic.src and/or body exists.

Issue initially raised here for reference cgkineo/adapt-hint#16

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions