Skip to content

Conversation

waddason
Copy link
Contributor

@waddason waddason commented Nov 1, 2024

Issue
While tuning hyper-parameters with a LeverageBagging classifier, I got an error when specifying the number_of_jobs but without using the minbatch_size parameter.
On instantiation, the classifier checks if minibatch_size <= 1 but minibatch is still None. This raises an exception.

Proposed solution
Switch the test order for minibatch_size, starting with the is None test.
The existing comments and documentation are still relevant.

@hmgomes
Copy link
Collaborator

hmgomes commented Nov 21, 2024

Hi @waddason , it took a while to get to this PR, but here we are. Thanks for raising the problem

Hi @cassales could you please assist with this one?

@cassales cassales changed the title fix: LeverageBagging switch minibatch_size test order fix: leveragingbagging parameter configuration Nov 21, 2024
Copy link
Collaborator

@cassales cassales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @waddason and @hmgomes,

I have taken a look, and indeed, I messed up. Thanks for fixing it, @waddason!
The only issue is that the commit message does not comply with the project's standards.
Please amend it to have all lowercase and less than 80 characters.

@waddason waddason force-pushed the LeverageBagging_fix branch from babf653 to 0ab4086 Compare November 22, 2024 08:07
@waddason
Copy link
Contributor Author

Hi @cassales , I have amended the commit message. Do you need any other action from my part ?

@cassales cassales merged commit 5c67fc9 into adaptive-machine-learning:main Feb 20, 2025
3 checks passed
justinuliu pushed a commit to AlejandroUN/Stream-Random-Histogram-Forest that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants