New: Move route definitions to routes.json (fixes #10)#11
Closed
New: Move route definitions to routes.json (fixes #10)#11
Conversation
Co-authored-by: taylortom <1059083+taylortom@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor route definitions to use routes.json
refactor: move route definitions to routes.json
Feb 26, 2026
Contributor
|
Closing in favour of #12 which will include these changes with fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces imperative route setup in
UserGroupsModulewith a declarativeroutes.json, aligning with the ecosystem-wide refactor whereAbstractApiModule.setValues()callsloadRouteConfigautomatically.Update
this.rootassignment andthis.useDefaultRouteConfig()call fromsetValues()— both are now handled byAbstractApiModulevialoadRouteConfigNew
routes.jsondeclaringroot: "usergroups"; noroutesarray needed since this module uses only the default CRUD routes provided byAbstractApiModuleTesting
npm test— all tests pass (pre-existing failure for missingadapt-authoring-apidev dependency is unrelated)/usergroupsOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.