refactor(datasets): Fix mypy for PathologicalPartitioner test
#5989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Maintainer
psfoley
added a commit
that referenced
this pull request
Oct 10, 2025
* Compare hash of received and expected FAB on Supernode Signed-off-by: Patrick Foley <patrick@flower.ai> * Signature verification pending Signed-off-by: Patrick Foley <patrick@flower.ai> * Logic for supernode to reject FAB if not signed by trusted entity Signed-off-by: Patrick Foley <patrick@flower.ai> * Remove changes to exit codes Signed-off-by: Patrick Foley <patrick@flower.ai> * feat(framework): Use `NoOp*Plugin` by default (#5974) Co-authored-by: Javier <jafermarq@users.noreply.github.com> * feat(framework): Merge `Linkstate.create_node` and `Linkstate.set_node_public_key` (#5977) Co-authored-by: Javier <jafermarq@users.noreply.github.com> Co-authored-by: Daniel J. Beutel <daniel@flower.ai> * Add ed25519 helper functions to primitives package. Unified API for this functionality to come in future PR. Removed FAB hash verification per review comments Signed-off-by: Patrick Foley <patrick@flower.ai> * Add enable-entity-verification flag Signed-off-by: Patrick Foley <patrick@flower.ai> * Fix missing parentheses Signed-off-by: Patrick Foley <patrick@flower.ai> * Fix misnamed variables Signed-off-by: Patrick Foley <patrick@flower.ai> * feat(framework): Add `public_key` field to `NodeInfo` and require `owner_aid` for node creation (#5985) Co-authored-by: jafermarq <javier@flower.ai> * refactor(framework): Implement `flwr supernode create` functionality (#5981) Co-authored-by: Heng Pan <pan@flower.ai> * refactor(framework): Implement `flwr supernode delete` functionality (#5987) Co-authored-by: Heng Pan <pan@flower.ai> Co-authored-by: Flower <148336023+flwrmachine@users.noreply.github.com> * refactor(framework): Check for `flwr_aid` before deleting a node (#5988) * Update framework/py/flwr/supernode/start_client_internal.py Co-authored-by: Yan Gao <yan@flower.ai> * refactor(datasets): Fix `mypy` for PathologicalPartitioner test (#5989) * refactor(datasets): Clarify seed parameter impact in partitioners (#5948) Co-authored-by: jafermarq <javier@flower.ai> * Add FAB timestamp verification for consistency Signed-off-by: Patrick Foley <patrick@flower.ai> * Revert "Merge remote-tracking branch 'origin' into verify-app-on-supernode" This reverts commit 55c2a5b, reversing changes made to fba335a. * Add new exit code when trust entity list is required. Move the failure to supernode launch Signed-off-by: Patrick Foley <patrick@flower.ai> * Fix * Fix signature format convertion * Update platform-api address --------- Signed-off-by: Patrick Foley <patrick@flower.ai> Co-authored-by: Heng Pan <pan@flower.ai> Co-authored-by: Javier <jafermarq@users.noreply.github.com> Co-authored-by: Daniel J. Beutel <daniel@flower.ai> Co-authored-by: jafermarq <javier@flower.ai> Co-authored-by: Flower <148336023+flwrmachine@users.noreply.github.com> Co-authored-by: yan-gao-GY <yan@flower.ai> Co-authored-by: Alireza Ghasemi <agcombest@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #5948