ci(framework): Use uv to run e2e tests with Python 3.10
#5741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Maintainer
chongshenng
requested review from
Robert-Steiner,
danieljanes and
tanertopal
as code owners
danieljanes
reviewed
Aug 20, 2025
chongshenng
changed the title
uv to run e2e testsuv to run e2e tests with Python 3.10
danieljanes
reviewed
Aug 20, 2025
Comment on lines
+218
to
+224
| # - name: Cache Python location | ||
| # if: ${{ needs.changes.outputs.framework == 'true' }} | ||
| # id: cache-restore-python | ||
| # uses: actions/cache/restore@v4 | ||
| # with: | ||
| # path: ${{ env.pythonLocation }} | ||
| # key: pythonloc-${{ runner.os }}-${{ matrix.directory }}-${{ env.pythonLocation }}-${{ hashFiles(format('./framework/e2e/{0}/pyproject.toml', matrix.directory)) }} |
Member
There was a problem hiding this comment.
Why is this commented out? We tend to delete thing instead of commenting them out
Member
Author
There was a problem hiding this comment.
Thanks for highlighting. I mentioned this in the comment of this PR - the idea was to remind us to swap it out to uv caching later. But we can remove it to maintain cleanliness.
chongshenng
commented
Aug 20, 2025
Comment on lines
261
to
263
| # - name: Run reconnection test with SQLite database (Temporarily disabled due to in-memory ObjectStore) | ||
| # if: ${{ needs.changes.outputs.framework == 'true' && matrix.directory == 'e2e-bare' }} | ||
| # run: ./../test_reconnection.sh sqlite |
Member
Author
There was a problem hiding this comment.
@danieljanes Based on your comment, should we delete these lines too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our
e2etests, the dependency resolution of some frameworks can take very long and time-out after 10 minutes, for example ine2e-tensorflow. Caching can help overall, but it still relies on the dependencies to be resolved in the first place.This PR introduces
uvinto our CI to resolve any dependencies in oure2etests, with the long term view of:uvin our workflows.Note that the Python caching is commented out and left in the CI script to facilitate switching to
uvcaching later.Merge before
e2etest #5742