Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(*:skip) Add version bumping script #4205

Merged
merged 16 commits into from
Oct 11, 2024
Merged

ci(*:skip) Add version bumping script #4205

merged 16 commits into from
Oct 11, 2024

Conversation

charlesbvll
Copy link
Member

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@charlesbvll charlesbvll marked this pull request as ready for review September 13, 2024 17:52
@Robert-Steiner Robert-Steiner self-requested a review September 23, 2024 14:41
Robert-Steiner
Robert-Steiner reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@Robert-Steiner Robert-Steiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice script!
Can we also include updating the flwr default version in the docker compose files?

dev/update_version.py Outdated Show resolved Hide resolved
dev/update_version.py Outdated Show resolved Hide resolved
Robert-Steiner
Robert-Steiner reviewed Sep 24, 2024
View reviewed changes
dev/update_version.py Outdated Show resolved Hide resolved
dev/update_version.py Outdated Show resolved Hide resolved
Robert-Steiner
Robert-Steiner previously approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@Robert-Steiner Robert-Steiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! The script looks good to me. However, I have not tested/reviewed the examples.

@danieljanes danieljanes enabled auto-merge (squash) October 11, 2024 12:14
@danieljanes danieljanes merged commit 20dfa78 into main Oct 11, 2024
53 checks passed
@danieljanes danieljanes deleted the add-version-bumping-script branch October 11, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@Robert-Steiner Robert-Steiner Robert-Steiner left review comments

@jafermarq jafermarq Awaiting requested review from jafermarq jafermarq is a code owner

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charlesbvll @danieljanes @Robert-Steiner