[core] CPD: Removed file filter for files that are explicitly specified on the CPD command line using the '--files' command line option. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…D command line using the '--files' command line option.
|
Thanks! |
adangel
pushed a commit
that referenced
this pull request
Apr 10, 2016
adangel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At TIOBE we want to use CPD to check duplicated code for TypeScript and XAML with the built-in Ecmascript and JSP tokenizers. The TypeScript syntax resembles Javascript and XAML files are XML files, just as JSP files.
Unfortunately we cannot use the built-in tokenizers, because CPD rejects the files because the file extensions do not match '.js' or '.jsp'. To fix this problem, I removed the file filter when a user explicit specifies a file name on the CPD command line instead of a directory. I think this is a rare use case, a normal user will specify a directory containing the source files, so it is safe to assume that the user knows what he is doing.