Tidy up #73
Merged
Tidy up #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since they aren't used, removing them
I did it since the second argument wasn't used
Requiring incanter instead of using use, since it's idiomatic
Doc strings come before arguments vector
Requiring it with an alias as it's idiomatic
Using an alias within require, over use, as it's more idiomatic
Removed the extra whitespace. All the files that I touched added this change, since somebody else coming after me might get tripped up by this, I'm adding this.
Made the git commands cut & paste friendly. It is just the redirection of the output to a file, but the less the user has to "figure out" when reading the README, the nicer their experience.
|
Solid PR -- thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started to read your Software Design X-Rays and then came across this repo.
Still not finished with the book, but I had a look at the code and there were small changes/tidy ups.
See what you make of it.
A summary:
requireoveruse, especially when it comes toinchanter