-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test against multiple rails versions #15
Open
kjvarga
wants to merge
751
commits into
adamsalter:master
Choose a base branch
from
kjvarga:kvarga/rails-integration-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Test against multiple rails versions #15
kjvarga
wants to merge
751
commits into
adamsalter:master
from
kjvarga:kvarga/rails-integration-tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support integer timestamps. Upgrade to v4.3.1
Fix list numbers and format in README
…rs/sitemap_generator into uncompressed-sitemaps Conflicts: Gemfile.lock VERSION
Add comments. Replace :gzip_zero with a :compress option. Upgrade to version 5 beta. Modify the SimpleNamer to strip .gz extensions if not compressing
Move compress option to the location object. More cleanup of deprecated methods.
Mimic the old SitemapNamer behaviour in the SitemapLocation
* Don't use ends_with?
All specs passing!
Remove deprecated config and tests.
Add specs Update README
* Pass link count in the call to write() so we can display it in the summary line * Fix referencing filesize and class constant in summary
setting path_style to true is necessary to make bucket with dots in the name work on https and avoid ssl certificate problems
expose fog_path_style configuration
…options. Update README
added Capistrano 3.x tasks
* Move verbose attr_accessor to attr_writer as we already have a custom reader * Remove sitemaps_host from attr_accessors as we have custom methods for both reading and writing * Fix number helper rounding spec that breaks in Ruby 2
…into laurynas-master
Don't delete the files after upload because we need them to read the file size. TODO: Handle this more elegantly. Perhaps set the file size into the location from the FileAdapter.
* Add CircleCI config for testing multiple rubies * Fix directory name * Use https * Try to specify bundler version * Try 2.8 * Try 2.7 * Remove ruby version from the lock file * Include lock file so the build works * Update dependencies * Add the junit formatter so the orb works * Allow caching and use bundler version from lock files * Update lock file * Use Ruby 3.1 * Fix the error assertion for ruby 3.1 * Cleanup config
… they can be generated in CI for each version of ruby
…on of nokogiri for ruby 2.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.