Add startTask config item to Azure #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
pditommaso
reviewed
Apr 11, 2024
|
|
||
| static AzStartTaskOpts parseStartTask(Map startTaskOpts) { | ||
| final newStartTaskOpts = new AzStartTaskOpts() | ||
| newStartTaskOpts.script = startTaskOpts.script ?: '' |
There was a problem hiding this comment.
Suggested change
| newStartTaskOpts.script = startTaskOpts.script ?: '' | |
| newStartTaskOpts.script = startTaskOpts.script |
null is better
pditommaso
reviewed
Apr 11, 2024
Comment on lines
+50
to
+51
| // !opts.startTask | ||
| // !opts.startTaskPrivileged |
There was a problem hiding this comment.
Still doesn't work yet. This is to remind me to add a test back in for the new class.
Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
adamrtalbot
commented
Apr 11, 2024
| this.startTask = opts.startTask | ||
| this.startTaskPrivileged = opts.startTaskPrivileged ?: false | ||
| this.maxVmCount = opts.maxVmCount as Integer ?: vmCount * 3 | ||
| this.startTask = getStartTask( opts.startTask as Map ) |
There was a problem hiding this comment.
@pditommaso why does this not work? I always get an empty AzStartTaskOpts class.
There was a problem hiding this comment.
Hard to say. I'd suggest you work in branch of the main repo instead of your own fork, otherwise I cannot contribute changes back
There was a problem hiding this comment.
Alright, pushed to the original dev branch
There was a problem hiding this comment.
Guess what, the problem was I was using nextflow instead of my dev branch 🤦
adamrtalbot
merged commit b53386c
into
azure_batch_configurable_start_task
1 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds startTask config set to Azure config options