Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect DOTNET_HOST_PATH if set #1034

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

iwillspeak
Copy link
Contributor

The variable DOTNET_HOST_PATH is used by dotnet to expose the path to the current invocation of the host. Tools should use it when making nested calls.

https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-environment-variables#dotnet_host_path

@iwillspeak iwillspeak changed the title feat: Rexpect $(DOTNET_HOST_PATH) If Set feat: Respect $(DOTNET_HOST_PATH) If Set Aug 5, 2024
@adamralph adamralph changed the title feat: Respect $(DOTNET_HOST_PATH) If Set Respect DOTNET_HOST_PATH if set Aug 15, 2024
The variable `DOTNET_HOST_PATH` is used by `dotnet` to expose the path to the current invocation of the host. Tools should use it when making nested calls.

<https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-environment-variables#dotnet_host_path>
@adamralph adamralph added the enhancement New feature or request label Aug 15, 2024
@adamralph adamralph added this to the 5.1.0 milestone Aug 15, 2024
@adamralph adamralph merged commit 42f35a0 into adamralph:main Aug 15, 2024
15 checks passed
@adamralph
Copy link
Owner

@iwillspeak thanks for raising this PR. I've released it in 5.1.0-rc.1—please feel free to give it a try.

@adamralph
Copy link
Owner

re-released as 6.0.0-rc.1 because the next release contains at least one breaking change

@iwillspeak
Copy link
Contributor Author

Awesome 🎉 . Thanks for taking the time to give it a review. I look forward to giving it a test drive

@iwillspeak iwillspeak deleted the patch-1 branch August 15, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants