Skip to content

Commit

Permalink
drop support for .NET Core
Browse files Browse the repository at this point in the history
  • Loading branch information
adamralph committed Nov 26, 2022
1 parent aa85c3c commit ea9faa6
Show file tree
Hide file tree
Showing 11 changed files with 9 additions and 20 deletions.
1 change: 0 additions & 1 deletion .cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
"MINVERVERSIONOVERRIDE",
"MyGet",
"Nerdbank",
"netcoreapp",
"netstandard",
"NOLOGO",
"notnull",
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,6 @@ jobs:
sdk: "6.0.403"
sdk-major-minor: "6.0"
# current Linux, all
- job:
os: ubuntu-22.04
tests:
framework: netcoreapp3.1
sdk: "3.1.425"
sdk-major-minor: "3.1"
- job:
os: ubuntu-22.04
tests:
Expand Down
4 changes: 2 additions & 2 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"version": "0.2.0",
"configurations": [
{
"name": ".NET Core Launch (console)",
"name": ".NET Launch (console)",
"type": "coreclr",
"request": "launch",
"program": "${workspaceFolder}/targets/bin/Debug/net7.0/Targets.dll",
Expand All @@ -12,7 +12,7 @@
"console": "internalConsole"
},
{
"name": ".NET Core Attach",
"name": ".NET Attach",
"type": "coreclr",
"request": "attach",
"processId": "${command:pickProcess}"
Expand Down
2 changes: 1 addition & 1 deletion MinVer.Lib/MinVer.Lib.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<IsPackable>false</IsPackable>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFrameworks>net6.0;net7.0</TargetFrameworks>
<LangVersion>default</LangVersion>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion MinVer/MinVer.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<RollForward>major</RollForward>
<SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
<TargetFrameworks>netcoreapp3.1;net6.0;net7.0</TargetFrameworks>
<TargetFrameworks>net6.0;net7.0</TargetFrameworks>
<LangVersion>default</LangVersion>
</PropertyGroup>

Expand Down
3 changes: 1 addition & 2 deletions MinVer/build/MinVer.targets
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
<PropertyGroup>
<MinVerDetailed>low</MinVerDetailed>
<MinVerDetailed Condition="'$(MinVerVerbosity)' == 'detailed' Or '$(MinVerVerbosity)' == 'd' Or '$(MinVerVerbosity)' == 'diagnostic' Or '$(MinVerVerbosity)' == 'diag'">high</MinVerDetailed>
<MinVerTargetFramework>netcoreapp3.1</MinVerTargetFramework>
<MinVerTargetFramework Condition="'$(MSBuildAssemblyVersion)' &gt;= '17.0'">net6.0</MinVerTargetFramework>
<MinVerTargetFramework>net6.0</MinVerTargetFramework>
<MinVerTargetFramework Condition="'$(MSBuildAssemblyVersion)' &gt;= '17.4'">net7.0</MinVerTargetFramework>
<NoWarn>$(NoWarn);NU5105</NoWarn>
</PropertyGroup>
Expand Down
3 changes: 0 additions & 3 deletions MinVerTests.Infra/MinVerCli.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ public static class MinVerCli
}

public static string GetPath(string configuration) =>
#if NETCOREAPP3_1
Solution.GetFullPath($"minver-cli/bin/{configuration}/netcoreapp3.1/minver-cli.dll");
#endif
#if NET6_0
Solution.GetFullPath($"minver-cli/bin/{configuration}/net6.0/minver-cli.dll");
#endif
Expand Down
2 changes: 1 addition & 1 deletion MinVerTests.Infra/MinVerTests.Infra.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<IsPackable>false</IsPackable>
<TargetFrameworks>netcoreapp3.1;net6.0;net7.0</TargetFrameworks>
<TargetFrameworks>net6.0;net7.0</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion MinVerTests.Lib/MinVerTests.Lib.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<RollForward>major</RollForward>
<TargetFrameworks>netcoreapp3.1;net6.0;net7.0</TargetFrameworks>
<TargetFrameworks>net6.0;net7.0</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Also available as a [command-line tool](#can-i-use-minver-to-version-software-wh

## Prerequisites

- [.NET Core SDK 3.1 or later](https://www.microsoft.com/net/download)
- [.NET SDK 6.0 or later](https://www.microsoft.com/net/download)
- [Git](https://git-scm.com/)

## Quick start
Expand Down
2 changes: 1 addition & 1 deletion minver-cli/minver-cli.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<RollForward>major</RollForward>
<RootNamespace>MinVer</RootNamespace>
<TargetFrameworks>netcoreapp3.1;net6.0;net7.0</TargetFrameworks>
<TargetFrameworks>net6.0;net7.0</TargetFrameworks>
<ToolCommandName>minver</ToolCommandName>
<LangVersion>default</LangVersion>
</PropertyGroup>
Expand Down

0 comments on commit ea9faa6

Please sign in to comment.