-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/unknown Android classes #76
Conversation
hey @EdricChan03 👋 Are you able to check out this branch, publish to to Maven Local, and give it a go in your project? I think it should fix your issue. (the tests are failing because of a inconsequential difference in the generated HTML) |
Thanks a lot for checking! It's a good sign. I'm not sure what the problem might be with the index.html file. Possibly it's a bug from another change I've made since v1.3.0. I'll finish up the work in this PR and if there's another bug to fix, then we can make a new issue for it. |
…e.properties` files can be configured using a DSL
- bump Android to 4.2.2 (because there's no Gradle plugin ID in previous versions, unknown reasons...) - lots of hacking around in DokkatooAndroidAdapter to fetch the files (the trick seems to be removing withVariantReselection()) - try using resolvedArtifacts instead of artifactFiles (might help with - hack around with the Dokka test project setup Gradle task (should be improved)
5d34f1e
to
0600a2f
Compare
modules/dokkatoo-plugin/src/main/kotlin/adapters/DokkatooKotlinAdapter.kt
Show resolved
Hide resolved
…rnal.instantiation.ClassGenerationException: Could not generate a decorated class for type DokkatooAndroidAdapter.
…lasses # Conflicts: # buildSrc/src/main/kotlin/buildsrc/conventions/maven-publish-test.gradle.kts # modules/dokkatoo-plugin-integration-tests/build.gradle.kts
Hopefully will improve #71
Error class: unknown class
in generated HTML #71 (comment))local.properties
is generated properly)Failed to install the following Android SDK packages as some licences have not been accepted.
error on GitHub actionSignificant changes
DokkaSourceSetIdSpec.sourceSetName
mutability has been deprecated. Instances of this class is used in Sets, and so its hashcode/equals must remain constant.