-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add syntactic sugar for getting the current Fiscal{Year,Quarter}. #4
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 254 262 +8
=====================================
+ Hits 254 262 +8
Continue to review full report at Codecov.
|
Thanks! I'll try to get a chance to review this and your other PR sometime in the next week. I have exams coming up (student life...) so I apologize if I get side-tracked. Ping me if I don't respond in a week. |
ping! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty solid! Just a few minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple last minute changes.
Ping @pmav99. Aside from my last 2 requested changes, I think this PR is ready to go! |
|
||
.. code-block:: python | ||
|
||
>>> from fiscalyear import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove import here too
2516342
to
7655cae
Compare
@@ -26,13 +26,18 @@ The ``FiscalYear`` class provides an object for storing information about the st | |||
|
|||
.. code-block:: python | |||
|
|||
>>> from fiscalyear import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add this import back
Thanks for the PR! I'll play around with the docs and do some testing and try to put out a new release by the end of the week. Sorry it took so long to get this merged! |
Fixes #2
I had to add
pytest-mock
in the dependencies.I also thought that it would be better if a native speaker wrote the docs.
Anyway, check it out and let me know of any remarks.